Resolve crash in nmos::server::close #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pplx::observe_exceptions Add pplx::details::wait_nothrow
Fixes Visual Studio build
garethsb
force-pushed
the
default-task-workaround
branch
2 times, most recently
from
3c94d30 to
972e59e
Compare
…oid task result type and simplify usage
garethsb
force-pushed
the
default-task-workaround
branch
from
972e59e to
734685c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to @SvenKordon, Rohde & Schwarz GmbH, for identifying and discussing this issue in #258.
The underlying issues have been raised on cpprestsdk (linked from above), but this PR provides a general purpose workaround within nmos-cpp.