Add discovery_mode setting #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng host names instead of IP addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default in HTTP (rather than HTTPS) mode, nmos-cpp makes Registration API connections using IP addresses. In some environments, it is important for the HTTP request to receive a
Hostheader. This setting allows nmos-cpp to be configured to do this, via a new overload ofnmos::experimental::resolve_service, but the existing behaviour is kept by default.Two functions that are likely only used by nmos-cpp itself,
nmos::get_service_protocolandnmos::get_service_authorizationare changed to take an additionalnmos::service_typeparameter. Apart from that, it's all backward compatible.