Skip to content

Conversation

@garethsb
Copy link
Contributor

ST 2110-20 requires whitespace after the semicolon within format-specific parameters:

tempFileForShare_20220825-064715

However, RFC 4566 (and RFC 8866) doesn't specify this syntax, and many examples, in both RFCs and SMPTE specs, show semicolon used as separator with no following whitespace.

We relaxed the SDPoker check some time ago... AMWA-TV/sdpoker#6.

Note that this does not accept whitespace preceding the semicolon, partly because I'm lazy and handling trailing whitespace after the last parameter (with no semicolon) is a harder change, and because ST 2110-20 also says no whitespace within the name or value.

@garethsb
Copy link
Contributor Author

garethsb commented Aug 25, 2022

Should we also change this line:

if (0 != params.size()) s += named_values_converter.format(params) + "; ";

to:

s += named_values_converter.format(params);

i.e. no trailing separator?

ST 2110-20:2022 requires no trailing semicolon, but some readers would argue that ST 2110-20:2017 required it to be present. (I argued for making it optional in the revision but seems like I didn't win that.)

I'll push a commit that makes that change too...

@garethsb
Copy link
Contributor Author

garethsb commented Sep 9, 2022

Note that this does not accept whitespace preceding the semicolon, partly because I'm lazy and handling trailing whitespace after the last parameter (with no semicolon) is a harder change

And now it does both of those, @lo-simon.

Copy link
Collaborator

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit 9f29022 into sony:master Sep 14, 2022
@garethsb garethsb deleted the fmtp-whitespace branch September 23, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants