GitHub actions: Version up deprecated upload-artifact and download-artifact REDUX #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
make_badgesaction, the download-artifact action is not downloading the test results.This is due to the
download-artifactbeing at v4 but theupload-artifactonly being bumped to v3 due to Node20 not being supported "out of the box" on the Ubuntu 14.04.According the https://github.com/actions/download-artifact one breaking change of the v4 of
download-artifactis "Downloading artifacts that were created from action/upload-artifact@v3 and below are not supported".For this reason v3 artifacts were being ignored by the v4
download-artifactaction, andmake_badgeswas failing.So this PR downgrades
download-artifactto v3.However this is a short term solution as v3 of the
download-artifactsandupload-artifactswill be deprecated from Nov 24.Therefore we need to either:
make_badgesprocess