Fix enum sequence and struct sequence validation #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathan-r-thorpe
commented
Oct 11, 2024
jonathan-r-thorpe
commented
- Enum sequences and struct sequences are failing the constraint validation even though they were valid.
- This is because the enum and struct sequences were not being treated like arrays.
- This PR fixes the problem.
- It also includes improved logging/error reporting.
- The draft MS-05-02 test suite in NMOS Testing has been updated to trap this bug.
lo-simon
requested changes
Oct 11, 2024
Collaborator
lo-simon
left a comment
lo-simon
left a comment
There was a problem hiding this comment.
Suggest minor changes. Rest LGTM.
Co-authored-by: Simon Lo <simon.lo@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.