Skip to content

IS-12: Fix datatype constraints check for NcDatatypeDescriptorStruct #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lo-simon merged 2 commits into from
Oct 18, 2024
Merged

IS-12: Fix datatype constraints check for NcDatatypeDescriptorStruct #413

lo-simon merged 2 commits into from
Oct 18, 2024

Conversation

@jonathan-r-thorpe
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe commented Oct 17, 2024

  • Fixed checking of isSequence for Struct fields
  • Fixed checking of isNullable for Struct fields
  • Removed redundant iteration of sequences (this is done in the calling function)
  • Always checks datatype constraints for Struct field (not just when there aren't any NcParameterConstraints)
  • Improved testConstraints unit test to include testing of sequences and nullable Struct fields

lo-simon
lo-simon approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit 5bc8b7c into master Oct 18, 2024
@lo-simon lo-simon deleted the fix-datatype-constraints-check branch October 18, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lo-simon lo-simon lo-simon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathan-r-thorpe @lo-simon