Skip to content

IS-12: Ensure NcMethodResultError returned on error (not NcMethodResult) #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lo-simon merged 1 commit into from
Nov 5, 2024
Merged

IS-12: Ensure NcMethodResultError returned on error (not NcMethodResult) #415

lo-simon merged 1 commit into from
Nov 5, 2024

Conversation

@jonathan-r-thorpe
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe commented Nov 1, 2024

Consistently log and return NcMethodResultError on error

lo-simon
lo-simon approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit f549712 into master Nov 5, 2024
@jonathan-r-thorpe jonathan-r-thorpe deleted the fix-return-method-result-error branch March 17, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lo-simon lo-simon lo-simon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathan-r-thorpe @lo-simon