Add _or_defaults versions of the format-specific parameters parsing functions #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since an 'empty' fmtp attribute would appear the same at this abstraction, it's better to rely on reporting omission of specific required format-specific parameters
…equired parameters are omitted - these functions still throw if they encounter invalid values
Collaborator
|
It looks good to me, and yes, it would definitely be beneficial to add the _or_defaults to the other media types for completeness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
_or_defaultsversions of the format-specific parameters parsing functions; the current functions throw when required parameters are omitted. The intention is the new functions are for parsing partialfmtplines, not handling invalid values, so they can still throw in those circumstances.I should probably add
_or_defaultsversions for the other three media types even though none of those have required parameters, just so the naming and intended usage is clear?