Skip to content

Fix jwt-cpp INTERFACE library #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathan-r-thorpe merged 1 commit into from
Feb 13, 2025
Merged

Fix jwt-cpp INTERFACE library #431

jonathan-r-thorpe merged 1 commit into from
Feb 13, 2025

Conversation

@lo-simon
Copy link
Collaborator

@lo-simon lo-simon commented Feb 5, 2025 •
edited
Loading

The jwt-cpp is a header-only library and should be set as an INTERFACE library. The issue was reported on #414.

jonathan-r-thorpe
jonathan-r-thorpe approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-r-thorpe jonathan-r-thorpe merged commit a0723ad into sony:master Feb 13, 2025
9 checks passed
@jonathan-r-thorpe jonathan-r-thorpe deleted the fix-jwt-cpp-interface-library branch February 13, 2025 10:08
@lo-simon lo-simon mentioned this pull request Feb 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-r-thorpe jonathan-r-thorpe jonathan-r-thorpe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lo-simon @jonathan-r-thorpe