Skip to content

IS-12: Fix remove_sequence_item control protocol method #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lo-simon merged 3 commits into from
Feb 13, 2025
Merged

IS-12: Fix remove_sequence_item control protocol method #432

lo-simon merged 3 commits into from
Feb 13, 2025

Conversation

@jonathan-r-thorpe
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe commented Feb 10, 2025

Fix remove_sequence_item control protocol method:

  • Disallow the modification of read only sequences
  • Generate property changed event on modification of the sequence
  • Unit test added

lo-simon
lo-simon approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit 530bfce into master Feb 13, 2025
18 checks passed
@lo-simon lo-simon deleted the remove-read-only-sequence-item-bug branch February 13, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lo-simon lo-simon lo-simon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathan-r-thorpe @lo-simon