Skip to content

Conversation

@stew3254
Copy link

Cryptsetup is a tool to create an encrypted filesystems.
Certain information about these filesystems is located in /etc/crypttab.
This plugin will include the /etc/crypttab file to a sos report

**

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Cryptsetup is a tool to create an encrypted filesystems.
Certain information about these filesystems is located in /etc/crypttab.
This plugin will include the /etc/crypttab file to a sos report

**Signed-off-by: Ryan Stewart <ryan.stewart@canonical.com>**
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3948
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Mar 1, 2025

A couple of comments

As per Contribution Guidelines, you need to sign you commit. You should be able to do this via git commit -s --amend and then force push to your branch. This will get the DCO check to green.

Also, would the crypttab be an addition item to the block plugin, where we collect the likes of the following items already?

cryptsetup luksDump /dev/{dev}
clevis luks list -d /dev/{dev}

@TurboTurtle
Copy link
Member

Also, would the crypttab be an addition item to the block plugin, where we collect the likes of the following items already?

cryptsetup luksDump /dev/{dev}
clevis luks list -d /dev/{dev}

That's what I'm unsure of - should we move those items into this plugin, or just add the collection in this one to block?

@arif-ali
Copy link
Member

arif-ali commented Mar 1, 2025

That's what I'm unsure of - should we move those items into this plugin, or just add the collection in this one to block?

On second thought, I think it would make sense to move it here

@TurboTurtle
Copy link
Member

I'm onboard with that.

@stew3254 if you could update this PR to also move the cryptsetup and luks bits from the block plugin to this new plugin, that'd be a solid foundation for this.

@stew3254
Copy link
Author

stew3254 commented Mar 4, 2025

@TurboTurtle Sure, that works for me. I'll do that when I get some time. I'm not sure why my commit wasn't signed though because usually all of my commits are signed. I'll look into that

@arif-ali
Copy link
Member

@stew3254 any updates on this PR at all

@pmoravec
Copy link
Contributor

Kindly reminding to apply the requested changes.

@arif-ali
Copy link
Member

A new PR that was committed in August febbf2e may have overruled this PR. But, personally, I think it makes sense to have a separate plugin for crypttab. @stew3254 if you have time, it would be good to look at this again, and get this moving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants