-
Notifications
You must be signed in to change notification settings - Fork 596
[presets] Ensure that presets override config files #4087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[presets] Ensure that presets override config files #4087
Conversation
|
I'm checking the too-many-boolean-expressions linting error, will push a new change as soon as possible |
df2eb03 to
15364ae
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
15364ae to
10bc579
Compare
The default value for networking.namespaces in the file tests/report_tests/options_tests/options_tests_sos.conf is 100, while the value for this variable in tests/report_tests/options_tests/options_tests_preset.json is 200. To make sure that preset beats the config file we need to change the value from 100 to 200. Related: sosreport#4087 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
centos-stream-9 failure probably fixed via #4139 |
Good catch - could you pls. rebase this PR to |
10bc579 to
4aaf65f
Compare
|
Done |
pmoravec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me up to the comment of the new option.
Per the man pages: 'In other words, config files will override defaults, presets override config files, and command line values override presets and config files.' This commit is an attempt to ensure that any option in a preset has precedence/overrides an existing option in the config file. Related: RHEL-104463 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
4aaf65f to
535d6c3
Compare
The default value for networking.namespaces in the file tests/report_tests/options_tests/options_tests_sos.conf is 100, while the value for this variable in tests/report_tests/options_tests/options_tests_preset.json is 200. To make sure that preset beats the config file we need to change the value from 100 to 200. Related: sosreport#4087 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Per the man pages:
'In other words, config files will override defaults, presets override config files, and command line values override presets and config files.'
This commit is an attempt t on ensure that the
any option in a preset has precedence/overrides
an existing option in the config file.
Related: RHEL-104463
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines