-
Notifications
You must be signed in to change notification settings - Fork 596
[cleaner] Make cleaner's obfuscate_file properly working #4110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TurboTurtle
merged 1 commit into
sosreport:main
from
pmoravec:sos-pmoravec-cleaner-fix-calling-obfuscate_file
Aug 20, 2025
Merged
[cleaner] Make cleaner's obfuscate_file properly working #4110
TurboTurtle
merged 1 commit into
sosreport:main
from
pmoravec:sos-pmoravec-cleaner-fix-calling-obfuscate_file
Aug 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is three-fold: - obfuscate_file must clean file content and not filename - cleaner's main_archive must be populated by parsers first - obfuscate_file dont need short_name as it is always called with implicit value of short_name that cleaner will strip itself Closes: sosreport#4109 Closes: sosreport#4110 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
TurboTurtle
approved these changes
Aug 20, 2025
Member
TurboTurtle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫠
Contributor
Thanks! This seems to have fixed the failing test |
pafernanr
pushed a commit
to pafernanr/sos
that referenced
this pull request
Oct 2, 2025
The fix is three-fold: - obfuscate_file must clean file content and not filename - cleaner's main_archive must be populated by parsers first - obfuscate_file dont need short_name as it is always called with implicit value of short_name that cleaner will strip itself Closes: sosreport#4109 Closes: sosreport#4110 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
dwolstroRH
pushed a commit
to dwolstroRH/sos
that referenced
this pull request
Nov 5, 2025
The fix is three-fold: - obfuscate_file must clean file content and not filename - cleaner's main_archive must be populated by parsers first - obfuscate_file dont need short_name as it is always called with implicit value of short_name that cleaner will strip itself Closes: sosreport#4109 Closes: sosreport#4110 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is three-fold:
Closes: #4109
Closes: #4110
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines