-
Notifications
You must be signed in to change notification settings - Fork 595
[dnf] Add 'dnf updateinfo list cves' command #4120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add 'dnf updateinfo list cves' to the dnf plugin. Related: RHEL-94859 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
| "dnf list extras", | ||
| "dnf updateinfo info security", | ||
| "dnf updateinfo list --available", | ||
| "dnf updateinfo list cves", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the additional value to dnf updateinfo list --available?
The --available one already prints the errata ID so the details about CVEs and BZs/JIRAs from the cves output can be found on the errata page, when required. E.g. for line:
RHSA-2025:6966 Moderate/Sec. kernel-uki-virt-5.14.0-570.12.1.el9_6.x86_64
the page https://access.redhat.com/errata/RHSA-2025:6966 lists the CVEs that the cve output provides.
Or do you focus on scenarios where the cves output would be malformed due to malformed metadata on the system..? I simply miss the use case when this output can be valuable to extra collect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right that --available already prints the errata ID, so for a single check that's useful - the support engineer can go to that web page and check everything. But if you are interested in more than one errata, the output of list cves saves a lot of time and gives you a better overall review of the system, neatly grouped and in a clearer way that '--available' could do. Or even if you are just interested in the cves for whatever reason and not in the erratas, this new command gives you everything you need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm so this is a request to rather "postprocess" some collected data, than collect anything new. Similarly like we generate some xml output in sar plugin.
Here this command takes 3ish seconds to execute.
I dont know if it is worth of the cost..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the data about CVEs hasn't been collected at this point. Only this command will provide it, for all the packages installed in the system.
If you are concerned about these 3 seconds, we can gate it behind an option like we do with some of the rpm plugin captures.
If that's still not enough for you, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see collecting this data on a border line where pros ~= cons. So I am deferring to other reviewers for their opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I think gating it with an option (default off) could help here
Add 'dnf updateinfo list cves' to the dnf plugin.
Related: RHEL-94859
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines