Skip to content

Conversation

@pmoravec
Copy link
Contributor

@pmoravec pmoravec commented Sep 5, 2025

OpenShift OVN has both podman and crio runtimes and sos detects podman as the default one. While the containers triggering openshift_ovn enabledness are under crio runtime.

To proper plugin enabledness detection, we must make the runtime customisable.

Closes: #4123
Relevant: RHEL-110512


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4123
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

2 similar comments
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4123
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4123
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

This will allow containers = (..) to be checked against given runtime,
if it is not default one.

Related: sosreport#4123

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
OpenShift OVN has both podman and crio runtimes and sos detects podman
as the default one. While the containers triggering openshift_ovn
enabledness are under 'crio' runtime.

Closes: sosreport#4123
Relevant: RHEL-110512

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@pmoravec pmoravec force-pushed the sos-openshift-ovn-enable--by-crio-containers branch from a7f34dc to 10a2c59 Compare September 12, 2025 08:28
@arif-ali arif-ali added Status/Needs Review This issue still needs a review from project members Kind/Collection New or updated command or file collection labels Sep 12, 2025
@arif-ali arif-ali added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Status/Needs Review This issue still needs a review from project members labels Sep 16, 2025
pmoravec added a commit that referenced this pull request Sep 16, 2025
This will allow containers = (..) to be checked against given runtime,
if it is not default one.

Related: #4123

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@pmoravec pmoravec closed this in 3b1f1a7 Sep 16, 2025
@pmoravec pmoravec deleted the sos-openshift-ovn-enable--by-crio-containers branch September 16, 2025 12:40
pafernanr pushed a commit to pafernanr/sos that referenced this pull request Oct 2, 2025
This will allow containers = (..) to be checked against given runtime,
if it is not default one.

Related: sosreport#4123

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
pafernanr pushed a commit to pafernanr/sos that referenced this pull request Oct 2, 2025
OpenShift OVN has both podman and crio runtimes and sos detects podman
as the default one. While the containers triggering openshift_ovn
enabledness are under 'crio' runtime.

Closes: sosreport#4123
Relevant: RHEL-110512

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
dwolstroRH pushed a commit to dwolstroRH/sos that referenced this pull request Nov 5, 2025
This will allow containers = (..) to be checked against given runtime,
if it is not default one.

Related: sosreport#4123

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
dwolstroRH pushed a commit to dwolstroRH/sos that referenced this pull request Nov 5, 2025
OpenShift OVN has both podman and crio runtimes and sos detects podman
as the default one. While the containers triggering openshift_ovn
enabledness are under 'crio' runtime.

Closes: sosreport#4123
Relevant: RHEL-110512

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind/Collection New or updated command or file collection Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants