-
Notifications
You must be signed in to change notification settings - Fork 595
[gcp] Collecting RHUI details on GCP #4182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Enabling collection of RHUI connection details on RHEL with Google repositories Signed-off-by: Pawel Szubert <pbm@google.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
| # Collect zone.txt file from RHUI | ||
| curl_command = 'curl -v https://rhui.googlecloud.com/zone.txt' | ||
|
|
||
| rhui_package = self.exec_cmd('rpm -qa google-rhui-client-*') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to run an extra command. You can use either self.policy.package_manager.pkg_by_name('google-rhui-client') (if that is the package name), or self.policy.package_manager.all_pkgs_by_name_regex(r'google-rhui-client') for a regexp search.
| rhui_package = self.exec_cmd('rpm -qa google-rhui-client-*') | ||
| if (rhui_package['status'] == 0 and | ||
| 'google-rhui-client' in rhui_package['output']): | ||
| self.collect_cmd_output(curl_command) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding some timeout? Default is 600s and in case of some routing issues, you probably dont want to wait 10 minutes (while I assume the curl command should terminate within seconds).
pmoravec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in code.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines