-
Notifications
You must be signed in to change notification settings - Fork 595
[report] Support copying directories from containers #4191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Ideally, we should implement Our PR mimics this behaviour. Fully correct one would be to traverse the directory within the container (nontrivial in general) and iteratively copy individual files and/or symlinks and/or dirs - every copied piece would have to be prepped by Until there is a need of reliably copy symlinks within containers, that lengthy approach is not needed, imho. |
A minimalistic but efficient way of copying whole directory from a container. It does not work with "runas" where we call "cat", though. Resolves: sosreport#4190 Closes: sosreport#4191 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
41e3575 to
a248f26
Compare
A minimalistic but efficient way of copying whole directory from a container. It does not work with "runas" where we call "cat", though. Resolves: sosreport#4190 Closes: sosreport#4191 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Let add_forbidden_path to work on collected container files. Relevant: sosreport#4191 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
a248f26 to
382e565
Compare
Let add_forbidden_path to work on collected container files. Furthermore, add all files from copied container directory into copied_files to allow secrets obfuscation in postproc. Relevant: sosreport#4191 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
382e565 to
076599c
Compare
Let add_forbidden_path to work on collected container files. Furthermore, add all files from copied container directory into copied_files to allow secrets obfuscation in postproc. Relevant: sosreport#4191 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
076599c to
a1ebf82
Compare
A minimalistic but efficient way of copying whole directory from a container. It does not work with "runas" where we call "cat", though.
Moreover:
add_forbidden_pathon files collected from containerspostprocto work on themResolves: #4190
Closes: #4191
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines