update playback library to maestro #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
force-pushed
the
update-playback-library
branch
2 times, most recently
from
7196c49 to
9d3d799
Compare
janmonschke
reviewed
Jul 28, 2017
src/stream.js
Outdated
Contributor
|
What is the impact on the file size? |
Contributor
Author
|
@janmonschke We aren't serving hls on public api at the moment but we might do in the future |
Contributor
|
Before minification? |
Contributor
Author
|
no after |
janmonschke
reviewed
Jul 28, 2017
src/stream.js
Outdated
Contributor
There was a problem hiding this comment.
Would it be possible to use the api module for this?
Contributor
Author
There was a problem hiding this comment.
It was, but it doesn't work because it is a post request, and the api module wants to add the oauth token and also other things as form data, instead of query params.
tjenkinson
force-pushed
the
update-playback-library
branch
2 times, most recently
from
7219499 to
f7f02df
Compare
Contributor
Author
|
This requires #82 because the current version of npm installs peer dependencies by default, and this means some unnecessary packages are included. |
tjenkinson
force-pushed
the
update-playback-library
branch
from
fdeacec to
e2604c0
Compare
Contributor
Author
|
@janmonschke you happy with this? |
tjenkinson
force-pushed
the
update-playback-library
branch
from
e2604c0 to
c925b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maestro player api is different, but player-api.js is an adaptor so that we can keep the current api for now. Maybe in the future we will do a major release and make maestro's api public