Implement SC.stream.activateAudioElement() #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruderstein
approved these changes
Nov 16, 2017
tjenkinson
force-pushed
the
implement-activate-audio-element
branch
from
461ac8b to
33ec181
Compare
Contributor
Author
|
thanks @bruderstein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developers to activate the audio element (from a user interaction) so that something can be played later, at a time which is suitable for them.
This is needed because some browsers have a restriction which means playback won't start unless the
play()(orload()) call on the media element is from a user interaction.See #9 (comment) for more information.
Without this developers have to work around the problem by requesting the player for some track, and then calling
play()followed bypause(), just to achieve this.closes #9