This repository was archived by the owner on May 24, 2022. It is now read-only.
Merged
Conversation
katjuell
commented
Apr 19, 2022
katjuell
commented
Apr 19, 2022
katjuell
commented
Apr 19, 2022
katjuell
commented
Apr 19, 2022
katjuell
commented
Apr 19, 2022
katjuell
commented
Apr 19, 2022
bretthayes
suggested changes
Apr 20, 2022
Contributor
bretthayes
left a comment
bretthayes
left a comment
There was a problem hiding this comment.
Looks good! Dev and build works.
I think we should try and incorporate more semantic HTML elements going forward where we see fit instead of using divs everywhere. We can also clean more of this up later after our repo merge but if we see some easy wins, we could include them while we port pages/components over since we're already rewriting a lot. What do you think?
Contributor
Author
|
@bretthayes sounds like an awesome idea to me! |
bretthayes
approved these changes
Apr 28, 2022
Contributor
bretthayes
left a comment
bretthayes
left a comment
There was a problem hiding this comment.
Love the semantic HTML additions! Thanks heaps!! 😁
Just a few merge conflicts to fix up and then we're good to go!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42 by adding building/ parsing for individual podcast records. Also updates records to work within our new MD/ MDX build processes.
To Test