This repository was archived by the owner on May 24, 2022. It is now read-only.
Merged
Conversation
katjuell
commented
Mar 8, 2022
src/components/Actions/GetSourcegraphNowActions/getSourcegraphNowActions.module.scss
Show resolved
Hide resolved
katjuell
commented
Mar 8, 2022
katjuell
commented
Mar 8, 2022
katjuell
commented
Mar 8, 2022
katjuell
commented
Mar 8, 2022
bretthayes
suggested changes
Mar 9, 2022
Contributor
bretthayes
left a comment
bretthayes
left a comment
There was a problem hiding this comment.
Looks good! Just a few comments. Also, I noticed that all the forms are different between prod and local 🕵🏻♂️
Contributor
Author
|
@bretthayes just a couple of questions back to you as I wrap this up — I think everything else is resolved! Unsure why those forms look different — I don't think it's on our end, is it, if we are using the correct ids and all that? |
bretthayes
approved these changes
Mar 10, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25 and #24 by adding contact pages and converting the
createHubSpotfunction (formerly defined undercomponentsinto a hook.NB: There's currently a redirect for
request-trial, which we'll get to when we port over #10.To Test
contact.