4.0/CTA update by st0nebreaker · Pull Request #5762 · sourcegraph/about

st0nebreaker · 2022-09-22T14:40:31Z

Closes #5739

Changelog

Removes search code CTA from nav
Gives default values to CtaSection to ease re-usability
Updates all CTA's with new CTA & ensures all pages are using CtaSection where appropriate
4.0 Landing page CTA style option added (use 'outlineButtonWhiteText' to achieve the ss below)

Test

Ensure prettier has standardized the proposed changes.
Smoke test core pages outlined in ticket

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1203036268389824

cypress/e2e/scripts.test.ts

sourcegraph-bot · 2022-09-22T15:17:13Z

Notifying subscribers in CODENOTIFY files for diff 29d5ae2...fa9d787.

Notify	File(s)
@content-platform-team	src/components/CaseStudies/CaseStudyLayout.tsx src/components/CaseStudies/NewCaseStudyLayout.tsx src/components/CtaSection.tsx src/components/Layout/Header/DesktopNav.tsx src/components/Layout/Header/MobileNav.tsx src/components/WhitePaperPage.tsx src/pages/batch-changes.tsx src/pages/better-dev-onboarding.tsx src/pages/blog/[...slug].tsx src/pages/case-studies/index.tsx src/pages/code-insights.tsx src/pages/code-search.tsx src/pages/home/index.tsx src/pages/partner-podcast.tsx src/pages/pricing.tsx src/pages/resources.tsx src/pages/shift-left-the-good-parts.tsx src/pages/support.tsx src/pages/use-cases/code-health.tsx src/pages/use-cases/code-reuse.tsx src/pages/use-cases/code-security.tsx src/pages/use-cases/incident-response.tsx src/pages/use-cases/index.tsx src/pages/use-cases/onboarding.tsx src/pages/videos/product-tour.tsx

bretthayes

Great improvements all around! Love the defaults for the CtaSection component. This will make code-reuse much easier with this component.

Added a few screenshots and suggestions of some things I noticed:

src/components/CtaSection.tsx

src/components/WhitePaperPage.tsx

src/pages/resources.tsx

src/pages/shift-left-the-good-parts.tsx

cypress/e2e/scripts.test.ts

Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com>

bretthayes

Fantastic! ✨ Thanks Becca!

* DLS Long form content max width application * Merge conflict * 4.0/CTA update (#5762) * CTA trial update & default values * CTA update cont * Fin CTA trial updates * Prettier/Lint * 4.0 landing pg CTA style option * Update src/pages/shift-left-the-good-parts.tsx Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com> * CTA mobile stacking * Cta center content max w Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@Beccas-MacBook-Pro.local> Co-authored-by: Brett Hayes <bretthayes@live.ca> Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com> * Home page - 4.0 updates (#5755) * Init home pg changes * 4.0 banner updates * Integrations update * Rm hero bg * Rm unused imports * Lint/Pretty * Update src/pages/home/_Hero.tsx Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com> * Home mesh bg adjustments * mesh update * demo video * prettier and linting Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@Beccas-MacBook-Pro.local> Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com> Co-authored-by: Brett Hayes <bretthayes@live.ca> * Sourcegraph 4 landing page updates for launch day (#5758) * launch day wip * twitch and links * post launch social meta image * launch pills hero bg * thumbnails * cta section updates * Pricing page - 4.0 updates (#5718) * Rough redesign layout change * Comment * PricingPlan card UI * Adjust PricingPlanFeature * Enterprise color toggle * Cleanup * Sticky table headers * Lg table overall style setup & sticky headers * Feature list data * Feature_info dictionary * Prettier/Lint * Consolidate pricing data to it's own file * Re org Spotlight & All feature label/tooltip data * Reuse btns * Comment * Init accordion * Tooltip style adjustments * Type Feature dictionaries * Accordion icon toggle * Tooltip style * Mars gradient bg * FAQ links * Prettier/Lint * FAQ heading spacing * Fix map key error * Rm comment * Table mobile sizing * Lint/Prettier * Rename file * Copy change requests * Header spacing * Meta update * CTA change * Cont copy update * Rm comment * Cont copy updates * Mobile feature table * Copy updates & odd icon bug fix * Cont table mobile refine * Copy * Copy * copy edits and prettier Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@Beccas-MacBook-Pro.local> Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@Beccas-MBP.lan> Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@iPhonedariaJose.tulum.bionatural.mx> Co-authored-by: Brett Hayes <bretthayes@live.ca> * resourceListItem hover and landing hero mobile fix * last reference of get-started -> signup * Pricing copy updates (#5773) * Copy updates * Self-hosted code hosts tooltip copy Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@Beccas-MacBook-Pro.local> * feedback * allow 1 CTA button in CtaSection * update product tour youtube video * feedback * copy update * Feedback updates * Sourcegraph 4.0 launch blogs (#5623) Adding the 3 blog posts accompanying the launch of Sourcegraph 4.0: the code intelligence narrative, cloud announcement, and Sourcegraph 4.0 release post. Add sourcegraph-4.0.md Add code-intelligence-platform.md Add enterprise-cloud.md * remove Phabricator and CVS Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@Beccas-MBP.lan> Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@Beccas-MacBook-Pro.local> Co-authored-by: Becca Steinbrecher <59381432+st0nebraker@users.noreply.github.com> Co-authored-by: Becca Steinbrecher <becca.steinbrecher@sourcegraph.com@iPhonedariaJose.tulum.bionatural.mx> Co-authored-by: Alex Isken <alex.isken@sourcegraph.com>

Becca Steinbrecher added 2 commits September 22, 2022 09:22

CTA trial update & default values

02afb82

CTA update cont

8cb3d50

st0nebreaker added the team/content-platform label Sep 22, 2022

st0nebreaker added this to the A - Sprint 13 milestone Sep 22, 2022

st0nebreaker self-assigned this Sep 22, 2022

Becca Steinbrecher added 2 commits September 22, 2022 10:08

Fin CTA trial updates

7bd22a9

Prettier/Lint

681731a

st0nebreaker commented Sep 22, 2022

View reviewed changes

cypress/e2e/scripts.test.ts Show resolved Hide resolved

st0nebreaker requested a review from bretthayes September 22, 2022 15:16

st0nebreaker marked this pull request as ready for review September 22, 2022 15:16

4.0 landing pg CTA style option

ec78aa7

bretthayes mentioned this pull request Sep 22, 2022

Launch 4.0 related PRs #5764

Closed

5 tasks

bretthayes linked an issue Sep 22, 2022 that may be closed by this pull request

Update Get Started CTA link #5739

Closed

19 tasks

Merge branch 'main' into 4.0/cta-update

85cf359

bretthayes changed the base branch from 4.0-launch to main September 23, 2022 03:17

bretthayes changed the base branch from main to 4.0-launch September 23, 2022 03:17

bretthayes changed the base branch from 4.0-launch to main September 23, 2022 03:18

bretthayes changed the base branch from main to 4.0-launch September 23, 2022 03:19

bretthayes changed the base branch from 4.0-launch to main September 23, 2022 03:52

bretthayes changed the base branch from main to 4.0-launch September 23, 2022 04:22

Merge branch '4.0-launch' into 4.0/cta-update

2ae6f58

bretthayes suggested changes Sep 23, 2022

View reviewed changes

st0nebreaker and others added 3 commits September 23, 2022 07:57

Update src/pages/shift-left-the-good-parts.tsx

232e183

Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com>

CTA mobile stacking

aaffa42

Cta center content max w

fa9d787

st0nebreaker requested a review from bretthayes September 23, 2022 15:14

bretthayes approved these changes Sep 23, 2022

View reviewed changes

bretthayes merged commit b83c457 into 4.0-launch Sep 23, 2022

bretthayes deleted the 4.0/cta-update branch September 23, 2022 16:59

st0nebreaker added the ✨ 4️⃣.0️⃣ ✨ Sourcegraph 4.0 label Oct 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4.0/CTA update#5762

4.0/CTA update#5762
bretthayes merged 10 commits into4.0-launchfrom
4.0/cta-update

st0nebreaker commented Sep 22, 2022 •

edited by elzannewentzel

Loading

Uh oh!

Uh oh!

sourcegraph-bot commented Sep 22, 2022 •

edited

Loading

Uh oh!

bretthayes left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bretthayes left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

st0nebreaker commented Sep 22, 2022 • edited by elzannewentzel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Test

Uh oh!

Uh oh!

sourcegraph-bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bretthayes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bretthayes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

st0nebreaker commented Sep 22, 2022 •

edited by elzannewentzel

Loading

sourcegraph-bot commented Sep 22, 2022 •

edited

Loading