fix: cannot create context menu item with duplicate id (#231)

Author: KattMingMing

package.json

@@ -125,6 +125,7 @@
     "ts-key-enum": "^2.0.0",
     "uuid": "^3.3.2",
     "vscode-languageserver-types": "3.12.0",
+    "webext-domain-permission-toggle": "^0.0.2",
     "whatwg-url": "^6.2.1"
   }
 }

src/browser/types.ts

@@ -55,7 +55,6 @@ export interface StorageItems {
      * Overrides settings from Sourcegraph.
      */
     clientSettings: string
-    hasEnableDomainContextMenu: boolean
 }
 
 interface ClientConfigurationDetails {
@@ -94,7 +93,6 @@ export const defaultStorageItems: StorageItems = {
         },
     },
     clientSettings: '',
-    hasEnableDomainContextMenu: false,
 }
 
 export type StorageChange = { [key in keyof StorageItems]: chrome.storage.StorageChange }

src/extension/scripts/background.tsx

@@ -5,9 +5,9 @@ import '../../config/polyfill'
 import { without } from 'lodash'
 import { ajax } from 'rxjs/ajax'
 import { InitData } from 'sourcegraph/module/extension/extensionHost'
+import DPT from 'webext-domain-permission-toggle'
 import ExtensionHostWorker from 'worker-loader?inline!./extensionHost.worker'
 import * as browserAction from '../../browser/browserAction'
-import * as contextMenus from '../../browser/contextMenu'
 import * as omnibox from '../../browser/omnibox'
 import * as permissions from '../../browser/permissions'
 import * as runtime from '../../browser/runtime'
@@ -162,11 +162,6 @@ permissions.onRemoved(permissions => {
 })
 
 storage.addSyncMigration((items, set, remove) => {
-    if (!items.hasEnableDomainContextMenu) {
-        createEnableDomainContextMenu(() => {
-            storage.setSync({ hasEnableDomainContextMenu: true })
-        })
-    }
     if (items.phabricatorURL) {
         remove('phabricatorURL')
 
@@ -273,30 +268,6 @@ runtime.onMessage((message, _, cb) => {
     return
 })
 
-const ENABLE_SOURCEGRAPH_CONTEXT_MENU = 'ENABLE_SOURCEGRAPH_CONTEXT_MENU'
-function createEnableDomainContextMenu(callback?: () => void): void {
-    contextMenus.create(
-        {
-            id: ENABLE_SOURCEGRAPH_CONTEXT_MENU,
-            title: 'Enable Sourcegraph on this domain',
-            contexts: ['browser_action'],
-            onclick: (_: chrome.contextMenus.OnClickData, tab: chrome.tabs.Tab): void => {
-                if (!tab.url) {
-                    console.error('Could not get tab url to request permissions.')
-                    return
-                }
-                try {
-                    const url = new URL(tab.url)
-                    permissions.request([url.origin]).catch(err => console.error('Permissions request denied', err))
-                } catch {
-                    console.error('Could not get tab url to request permissions')
-                }
-            },
-        },
-        callback
-    )
-}
-
 function requestPermissionsForEnterpriseUrls(urls: string[], cb: (res?: any) => void): void {
     storage.getSync(items => {
         const enterpriseUrls = items.enterpriseUrls || []
@@ -468,3 +439,6 @@ chrome.runtime.onConnect.addListener(port => {
         )
     })
 })
+
+// Add "Enable Sourcegraph on this domain" context menu item
+DPT.addContextMenu()

yarn.lock

@@ -13648,6 +13648,11 @@ web-ext@^2.5.0:
     yargs "6.6.0"
     zip-dir "1.0.2"
 
+webext-domain-permission-toggle@^0.0.2:
+  version "0.0.2"
+  resolved "https://registry.yarnpkg.com/webext-domain-permission-toggle/-/webext-domain-permission-toggle-0.0.2.tgz#28003248699b869e5422b2ef60a7c2b03e1c3c15"
+  integrity sha512-obPAEocq/5uw0jaKc1N2bwux/HXDaYz9/8ltvxTRqr0iR6JaTh6/h56FL9uoAZYXcXxjFyE+PRrJicoQrJ8T6g==
+
 webidl-conversions@^4.0.1, webidl-conversions@^4.0.2:
   version "4.0.2"
   resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-4.0.2.tgz#a855980b1f0b6b359ba1d5d9fb39ae941faa63ad"