This repository was archived by the owner on Jan 22, 2019. It is now read-only.
fix: cannot create context menu item with duplicate id#231
Merged
KattMingMing merged 1 commit intomasterfrom Oct 6, 2018
Merged
fix: cannot create context menu item with duplicate id#231KattMingMing merged 1 commit intomasterfrom
KattMingMing merged 1 commit intomasterfrom
Conversation
ijsnow
approved these changes
Oct 4, 2018
ijsnow
left a comment
ijsnow
left a comment
There was a problem hiding this comment.
Nice, after we merge this I'm going to see if we actually need <all_urls> anymore on Firefox since we don't have a popover anymore
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #230:
Fixes bug where "Enable Sourcegraph on this domain" context menu item would not appear.
Uses a helper lib also used in refined GitHub to add the context menu item, request permissions, display any errors to the user, show alert to refresh page after permissions are granted so the content script is injected.
Testing plan:
I have tested on: