Duplicate hover contents

[sqs]

Repro:

1. "Use Sourcegraph extensions" = on
2. Go to https://github.com/theupdateframework/notary/blob/fb795b0bc868746ed2efa2cd7109346bc7ddf0a4/server/storage/rethinkdb.go
3. Hover over a token

The hover contents are duplicated, as though it's fetching them via the builtin LSP client and via the langserver/* extensions and merging them.

[chrismwendt]

I can't repro (Browser extension v1.14.0). Which extensions do you have enabled? There used to be the little "Ext" button in the bottom right, but I don't see it anymore - did it get removed?

[sqs]

Yes, I removed it because it was broken (no Router context, needed for the Links). No extensions other than the langserver/go extension. I’ll dig into it more

[chrismwendt]

I saw this briefly while working on something else, but I don't have a consistent repro.

[chrismwendt]

Got a repro:

• Disable the Go extension in the browser extension
• Go to https://github.com/gorilla/mux/blob/master/mux.go (keep this tab open)
• In a separate tab, enable the Go extension
• Hover over a token
• Notice duplicate hovers

Edit: actually, I'm able to repro simply by refreshing the page on mux.go with token-highlights as the only enabled extension.

[chrismwendt]

I noticed that this bug only manifests while the options page is open. I suspect this is happening because

browser-extensions/src/extension/scripts/background.tsx

Line 462 in 903acdd

chrome.runtime.onConnect.addListener(port => {

is being executed both in the background script and the options page (via a transitive import). That line it should only execute in the background script. To avoid this double execution, I'm looking into either splitting up the imports or conditionally executing that based on which script is running.

[chrismwendt]

Submitted a fix #182. The root cause was that I was transitively importing background.tsx from the options page, which caused multiple port listeners to be added, which caused duplicate messages to be sent to the content scripts.

I plan to completely prevent transitive imports of the entrypoints in another PR (edit: submitted #184).

[sourcegraph-bot]

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on:

• Firefox Add-on
• Chrome Web Store
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀