Skip to content
This repository was archived by the owner on Jan 22, 2019. It is now read-only.

feat: remove the Sourcegraph extension list#132

Closed
chrismwendt wants to merge 1 commit intomasterfrom
remove-extensions-list
Closed

feat: remove the Sourcegraph extension list#132
chrismwendt wants to merge 1 commit intomasterfrom
remove-extensions-list

Conversation

@chrismwendt
Copy link

⚠️ Don't merge this until the corresponding PR in sourcegraph/sourcegraph is merged (TODO(chris) add a link here)

This removes the extensions list from the browser extension. Adding/removing extensions will be handled on the Sourcegraph instance.

Resolves https://github.com/sourcegraph/browser-extensions/issues/127

TODO

  • Add communication between the browser extension and the Sourcegraph instance for adding/removing/enabling/disabling extensions

@chrismwendt chrismwendt requested a review from ijsnow as a code owner September 4, 2018 23:46
@chrismwendt chrismwendt force-pushed the remove-extensions-list branch from 72cde31 to ab4b025 Compare September 5, 2018 00:23
<Input onClick={this.onUseCXPToggled} defaultChecked={useCXP} type="checkbox" />{' '}
Use Sourcegraph extensions
Use Sourcegraph extensions (visit the registry at{' '}
<a href={`${sourcegraphUrl}/extensions`}>{`${sourcegraphUrl}/extensions`}</a>)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tips on wording here?

@sqs
Copy link
Member

sqs commented Oct 25, 2018

@chrismwendt Was this already merged? IIRC it was already incorporated into the browser extension, so this PR should be closed, right?

@chrismwendt
Copy link
Author

Yup, removed in #250

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants