Skip to content
This repository was archived by the owner on Jan 22, 2019. It is now read-only.

chore: run TSLint on all folders#65

Open
felixfbecker wants to merge 1 commit intomasterfrom
run-tslint-on-all-folders
Open

chore: run TSLint on all folders#65
felixfbecker wants to merge 1 commit intomasterfrom
run-tslint-on-all-folders

Conversation

@felixfbecker
Copy link

@felixfbecker felixfbecker commented Aug 20, 2018

Closes #64

To fix:

ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[114, 1]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[268, 5]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[276, 5]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/chrome/extension/background.tsx[321, 5]: Promises must be handled appropriately
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/extension/safari/StorageArea.ts[65, 40]: Explicit type parameter needs to be provided to the constructor
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/extension/storage.ts[91, 40]: Avoid referencing unbound methods which may cause unintentional scoping of 'this'.
ERROR: /Users/felix/src/github.com/sourcegraph/browser-extensions/extension/storage.ts[91, 50]: Avoid referencing unbound methods which may cause unintentional scoping of 'this'.

@felixfbecker felixfbecker force-pushed the run-tslint-on-all-folders branch from 406b388 to a9a8f1b Compare August 20, 2018 19:56
KattMingMing pushed a commit that referenced this pull request Aug 24, 2018
Hide tooltip on page navigation
@felixfbecker felixfbecker assigned ijsnow and unassigned KattMingMing Sep 3, 2018
@felixfbecker
Copy link
Author

@ijsnow can you confirm TSLint is now run on all folders?

@felixfbecker
Copy link
Author

So that is a no

@ijsnow
Copy link

ijsnow commented Oct 3, 2018

It's ran on all code that is ran by the browser extension

@felixfbecker
Copy link
Author

Tests in cypress/, the webpack configs in webpack/ and the scripts in scripts/ are all TypeScript and should be linted too

@chrismwendt
Copy link

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions

cd browser-extensions
git format-patch master --stdout > /tmp/patch

cd ../sourcegraph
cat /tmp/patch | git am -3 --directory=packages/browser-extensions/
# and fixup merge conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants