-
Notifications
You must be signed in to change notification settings - Fork 12
Add flag to specify filename other than CODENOTIFY #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c05120 to
09b43f5
Compare
|
@jhchabran Please take a look for early feedback. |
7bc4786 to
104fda0
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 515c85d...493cbc5.
|
this should be it🤞
9adcce6 to
493cbc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍!
I added some comments, which provide two possible ways to simplify the logic around passing the filename from GitHub actions.
I tend to prefer the first one (where we are using the binary as the entry point and using CMD to pass additional args to overrides the defaults, but I don't have a strong opinion either.
bobheadxi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach! Code LGTM as well :)
|
Happy to see you all running with this! This codebase was a bit of a hack project for me so feel free to take it from here and change whatever you want. I'll stay out of the code reviews unless you explicitly tag me :) |
Context
For RFC 551 APPROVED: Documenting ownership with OWNERS files, we are adding the ability to specify OWNERS of certain files/directories in our code base. We want this to behave in basically the exact same way as CODENOTIFY. However, being listed in CODENOTIFY doesn't necessarily mean you are an owner, so we need to keep the two lists separate.
As discussed in OWNERS in Sourcegraph: Implementation details, there aren't any off-the-shelf solutions that would do exactly what we want. In fact, Codenotify is the closest thing — so I decided to modify it slightly so that it can read OWNERS files as well as CODENOTIFY files.
This has the advantage that we would only have one tool and one file format to support for these two very similar purposes.
Changes in this PR
-filenameoption to the codenotify tool, with a default value of"CODENOTIFY".