This repository was archived by the owner on Nov 6, 2018. It is now read-only.
Conversation
|
I tried this out locally and I like how fast the feedback loop is. I'm not sure how often I'd use this, but at least I know how to add it to a project now 🙇 |
Author
|
It would also help in situations where we want others to just look at styles like in #48. |
|
Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/sourcegraph-extension-api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds storybooks to this project. This project is a react component library. This means that it should be able to run in many places out of the box. For developing libraries like this, tools like Storybooks are great. It's a fast development loop and forces you to write your code in modular and reusable ways since its an isolated environment. This means that you'll also move faster in the future since the code will be inherently more maintainable. In addition to this, Storybooks serves as documentation and can be used to integrate with unit tests and much more.
I'm not actively working on this project so I'm just going to leave this here for @chrismwendt and @sqs to decide if they want it. This project is the perfect use case for this type of tool and I encourage you to give it a try but it's up to you the owners and active maintainers of the project.