fix: Try to infer gem name and version. #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
force-pushed
the
vg/elide-gem-arg
branch
from
1d83062 to
c37c5cf
Compare
varungandhi-src
force-pushed
the
vg/elide-gem-arg
branch
from
c37c5cf to
973600d
Compare
varungandhi-src
commented
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This will be useful for auto-indexing because we'd like the indexer to infer the Gem name and version instead of having it be input from the command-line (the logic needs to live somewhere, so it might as well live in the indexer).
TODO:
--gem-metadataby default.Test plan
Tested manually against shopify-api-ruby. I will add some automated tests.