Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scip_indexer/SCIPIndexer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,12 @@ static bool isTemporary(const core::GlobalState &gs, const core::LocalVariable &
if (var.isSyntheticTemporary(gs)) {
return true;
}
return var._name == Names::finalReturn() || var._name == Names::blockPreCallTemp() ||
var._name == Names::blockTemp() || var._name == Names::blockPassTemp() || var._name == Names::forTemp();
auto n = var._name;
return n == Names::blockPreCallTemp() || n == Names::blockTemp() || n == Names::blockPassTemp() ||
n == Names::forTemp() || n == Names::blkArg() || n == Names::blockCall() ||
// Insert checks because sometimes temporaries are initialized with a 0 unique value. 😬
n == Names::finalReturn() || n == NameRef::noName() || n == Names::blockCall() || n == Names::selfLocal() ||
n == Names::unconditional();
}

struct LocalOccurrence {
Expand Down
2 changes: 1 addition & 1 deletion test/scip/scip_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def scip_test(path):
data = data,
size = "small",
)
update_test_name = "update_".format(test_name)
update_test_name = "update_{}".format(test_name)
native.sh_test(
name = update_test_name,
srcs = ["scip_test_runner.sh"],
Expand Down
12 changes: 12 additions & 0 deletions test/scip/testdata/for.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# typed: true

def for_loop()
y = 0
for x in [1, 2, 3]
y += x
for x in [3, 4, 5]
y += x
end
end
y
end
25 changes: 25 additions & 0 deletions test/scip/testdata/for.snapshot.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# typed: true

def for_loop()
#^^^^^^^^^^^^^^ definition scip-ruby gem TODO TODO for_loop().
#^^^^^^^^^^^ definition scip-ruby gem TODO TODO <static-init>().
y = 0
# ^ definition local 1~#1120785331
for x in [1, 2, 3]
# ^ definition local 2~#1120785331
y += x
# ^ reference local 1~#1120785331
# ^ reference (write) local 1~#1120785331
# ^ reference local 2~#1120785331
for x in [3, 4, 5]
# ^ definition local 3~#1120785331
y += x
# ^ reference local 1~#1120785331
# ^ reference (write) local 1~#1120785331
# ^^^^^^ reference local 1~#1120785331
# ^ reference local 3~#1120785331
end
end
y
# ^ reference local 1~#1120785331
end