Buggy hover extensions should not be able to break other hover providers

[nicksnyder]

The sourcegraph-string-references extension breaks code intelligence in certain places. This should not be possible.

If one hover provider fails, other hover providers should continue to work.

I don't know which component is responsible for this so I am filing on this repo. Feel free to move.

cc @chrismwendt @sqs @felixfbecker @ijsnow

[emidoots]

@nicksnyder I've updated the title here to reflect that this is in specific about hover providers. This is also true of other things in extensions, e.g. references providers like the issue https://github.com/sourcegraph/sourcegraph-extension-api/issues/82 talks about.

If you're aware of other specific cases of this, let's file separate issues for those since the fixes will likely be independent

[beyang]

I also encountered a similar issue:

All code intelligence was broken for me just now on sourcegraph.com. I went through and disabled all my extensions except Go and now it works again. This is the second time I've done that now (last time was a couple weeks back).

[emidoots]

@beyang If you can, please provide steps to reproduce it, e.g. what extensions did you have enabled that caused it?

[sourcegraph-bot]

🎉 This issue has been resolved in version 18.4.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀