This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Modify search to use search extensions #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| results { | ||
| ... on Repository { | ||
| export function search( |
Contributor
There was a problem hiding this comment.
When/how often does the returned Observable emit? (please document)
Contributor
Author
There was a problem hiding this comment.
@felixfbecker documented this a couple lines below
attfarhan
force-pushed
the
fa/search-extensions
branch
from
6456178 to
4679715
Compare
nicksnyder
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies search to go through the new search extensions. Every time a search request is made, the user's query goes through
transformQueryof any registered search providers.Depends on sourcegraph/sourcegraph-extension-api#95.