Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

remove deprecated REPO_URI (fixes #680)#6825

Merged
emidoots merged 1 commit intomasterfrom
sg/rm-deprecated
Nov 25, 2019
Merged

remove deprecated REPO_URI (fixes #680)#6825
emidoots merged 1 commit intomasterfrom
sg/rm-deprecated

Conversation

@emidoots
Copy link
Member

Fixes #680

@emidoots emidoots requested a review from a team November 25, 2019 07:35
Copy link
Contributor

@rvantonder rvantonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emidoots
Copy link
Member Author

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #6825 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6825      +/-   ##
==========================================
+ Coverage   39.19%   39.19%   +<.01%     
==========================================
  Files        1226     1226              
  Lines       62958    62958              
  Branches     6130     6130              
==========================================
+ Hits        24677    24679       +2     
+ Misses      36034    36033       -1     
+ Partials     2247     2246       -1
Impacted Files Coverage Δ
internal/search/backend/horizontal.go 90.32% <0%> (+1.61%) ⬆️

@emidoots emidoots merged commit b0e3a38 into master Nov 25, 2019
@emidoots emidoots deleted the sg/rm-deprecated branch November 25, 2019 07:49
@tsenart
Copy link
Contributor

tsenart commented Nov 25, 2019

@keegancsmith: Didn’t we start using URI again (undeprecated)?

@tsenart
Copy link
Contributor

tsenart commented Nov 25, 2019

In the context of supporting repositoryPathPattern in the browser extension.

https://github.com/sourcegraph/sourcegraph/pull/3922

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Followups to finish migration of repo uri -> name

3 participants

Comments