servegit: use error hook #1037
Merged
servegit: use error hook #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
reviewed
Sep 14, 2023
| return filepath.Join(s.Root, filepath.FromSlash(name)) | ||
| }, | ||
| ErrorHook: func(err error, stderr string) { | ||
| s.Info.Printf("git-service error: %s\nstderr:\n%s", err.Error(), stderr) |
Member
Author
There was a problem hiding this comment.
There is no error in this case.
Before this if the git command failed we would nil panic since the Logger on gitservice.Handler was not set. This commit updates us to the latest version of lib which instead takes in an error hook so we can use the attached stdlib logger. Test Plan: go test
keegancsmith
force-pushed
the
k/use-errorhook
branch
from
9352a4e to
7e1ab28
Compare
mrnugget
approved these changes
Sep 14, 2023
Member
Author
|
@DaedalusG fix for the nil panic is now in main :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this if the git command failed we would nil panic since the Logger on gitservice.Handler was not set. This commit updates us to the latest version of lib which instead takes in an error hook so we can use the attached stdlib logger.
Corresponding PR at https://github.com/sourcegraph/sourcegraph/pull/56611
Test Plan: go test