Fix windows installation #1098
Merged
Fix windows installation #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1050. Previously, it was not possible to install src-cli via npm on Windows. It was also not possible to publish the npm package on Windows. This PR fixes both problems. The second problem had to be solved so I could manually test the fix for this PR.:
burmudar
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1050. Previously, it was not possible to install src-cli via npm on Windows. It was also not possible to publish the npm package from a Windows computer. This PR fixes both problems. The second problem had to be solved so I could manually test the fix for this PR.:
Test plan
Manually tested locally on a Windows computer
verdacciopnpm unpublish --forcepnpm publishpnpm initpnpm add @sourcegraph/srcpnpm exec src login, confirmed it worked