Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/src/mcp.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func mcpMain(args []string) error {
if err := flags.Parse(flagArgs); err != nil {
return err
}
mcp.DerefFlagValues(vars)
mcp.DerefFlagValues(flags, vars)

if err := validateToolArgs(tool.InputSchema, args, vars); err != nil {
return err
Expand Down
30 changes: 11 additions & 19 deletions internal/mcp/mcp_args.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,36 +24,28 @@ func (s *strSliceFlag) String() string {
return strings.Join(s.vals, ",")
}

func DerefFlagValues(vars map[string]any) {
func DerefFlagValues(fs *flag.FlagSet, vars map[string]any) {
setFlags := make(map[string]bool)
fs.Visit(func(f *flag.Flag) {
setFlags[f.Name] = true
})

for k, v := range vars {
if !setFlags[k] {
delete(vars, k)
continue
}
rfl := reflect.ValueOf(v)
if rfl.Kind() == reflect.Pointer {
vv := rfl.Elem().Interface()
if slice, ok := vv.(strSliceFlag); ok {
vv = slice.vals
}
if isNil(vv) {
delete(vars, k)
} else {
vars[k] = vv
}
vars[k] = vv
}
}
}

func isNil(v any) bool {
if v == nil {
return true
}
rv := reflect.ValueOf(v)
switch rv.Kind() {
case reflect.Slice, reflect.Map, reflect.Pointer, reflect.Interface:
return rv.IsNil()
default:
return false
}
}

func BuildArgFlagSet(tool *ToolDef) (*flag.FlagSet, map[string]any, error) {
if tool == nil {
return nil, nil, errors.New("cannot build flagset on nil Tool Definition")
Expand Down
2 changes: 1 addition & 1 deletion internal/mcp/mcp_args_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func TestFlagSetParse(t *testing.T) {
if err := flagSet.Parse(args); err != nil {
t.Fatalf("flagset parsing failed: %v", err)
}
DerefFlagValues(vars)
DerefFlagValues(flagSet, vars)

if v, ok := vars["repos"].([]string); ok {
if len(v) != 2 {
Expand Down
Loading