mcp: add --json flag to all tool calls to provide args as a json object
#1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- include note section where we mention the precedence
keegancsmith
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--jsonflag for all tool calls exposed throughsrc mcp. By using--jsonan agent can provide values for all flags instead of using the cli flag ie.src mcp <tool-name> --json '{"query": "test", "repo": "github.com/sourcegraph/sourcegraph"}'instead ofsrc mcp <tool-name> --query "test" -repo "github.com/sourcegraph/sourcegraph"Note:
Values specified via
--jsontake precedence over values provided via flags.Test plan
--jsonflag and also mix the usage with normal flagsCloses CPL-13