Allow users to supply arbitrary HTTP headers for requests #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @ryanslade as a sanity check to ensure that this isn't undoing any work in deprecating non-envvar settings. |
garobrik
reviewed
Jul 1, 2020
emidoots
reviewed
Jul 1, 2020
emidoots
reviewed
Jul 1, 2020
Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>
mrnugget
approved these changes
Jul 2, 2020
Contributor
mrnugget
left a comment
mrnugget
left a comment
There was a problem hiding this comment.
Nice! Left some comments regarding documentation of this feature.
ryanslade
reviewed
Jul 2, 2020
ryanslade
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238.
This threads header values into the HTTP calls to the Sourcegraph instance via envvars such as
SRC_HEADER_FOO=BAR(whereFoo: barwould be the additional header value - note that header names are case insensitive).This is applied to:
This is notably to fix a particular customer's issue, which has their instance behind an authenticating proxy that accepts special bearer tokens.