servegit: eval symlinks on root #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a useful use case which allows changing your root by updating a symlink. Additionally it is convenient. We have to explicitly resolve the symlink since filepath.Walk does not support resolving symlinks. We resolve the symlink each time we crawl so the user can update the value of the symlink at runtime. Note: we still ignore symlinks with the repos directory. Supporting that would be more complex due to symlink cycles.
keegancsmith
force-pushed
the
k/symlink
branch
from
15fa89f to
0108103
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This is a useful use case which allows changing your root by updating a symlink. Additionally it is convenient. We have to explicitly resolve the symlink since filepath.Walk does not support resolving symlinks. We resolve the symlink each time we crawl so the user can update the value of the symlink at runtime. Note: we still ignore symlinks with the repos directory. Supporting that would be more complex due to symlink cycles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a useful use case which allows changing your root by updating a
symlink. Additionally it is convenient. We have to explicitly resolve
the symlink since filepath.Walk does not support resolving symlinks. We
resolve the symlink each time we crawl so the user can update the value
of the symlink at runtime. Note: we still ignore symlinks with the repos
directory. Supporting that would be more complex due to symlink cycles.
Fixes #453