Add batch_change.{name,description} as templating variables #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I create a batch change, and set a name, I am using a name from the batch change namespace. So it's clear to me what batch_change means here. Why is |
eseliger
approved these changes
Mar 10, 2021
Member
eseliger
left a comment
eseliger
left a comment
There was a problem hiding this comment.
I think when updating an existing campaign batch_change definitely makes sense and to not have to distinguish between (batch_change ?? batch_spec).name, I'd go with batch_change all the time. Nice addition 👍
Contributor
Author
|
I'll follow up with docs to |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add BatchChange name/description to templating vars * Add changelog * Add PR number to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #487 by adding
batch_change.nameandbatch_change.descriptionto the templating vars.I didn't want to use
batchbecause it's ambigious, but I'm also not 100% sure aboutbatch_changesince technically the batch change doesn't exist yet. So maybe it should bebatch_spec? But that's also not 100% clear cut.For code reviewers: note that I introduced a little helper struct. That might seem overblown, but while writing the code I realized that I'm about to pass the whole
BatchSpecaround if I don't add this helper thing. And if I were to pass the*BatchSpecto every*Taskand everyrunStepsthen we could get rid of all the intermediate steps, but then everything would need to dig deep into the*BatchSpec. If you think that's fine I can change it. I just thought that for now it's easier and safer to simply pass two duplicated strings around.