Remove old feature gates from pre-4.0 #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
force-pushed
the
es/cleanup-feature-gates
branch
2 times, most recently
from
685b513 to
fc3fa34
Compare
eseliger
force-pushed
the
es/cleanup-feature-gates
branch
from
d1039a3 to
efd1d7f
Compare
Piszmog
approved these changes
Aug 25, 2022
Contributor
Piszmog
left a comment
Piszmog
left a comment
There was a problem hiding this comment.
LGTM
I'm mentally preparing myself for the merge conflict I'm going to have to go thru.
LawnGnome
approved these changes
Aug 25, 2022
| return docker.NCPU(ctx) | ||
| } | ||
|
|
||
| func validateSourcegraphVersionConstraint(ctx context.Context, svc *service.Service) error { |
Contributor
There was a problem hiding this comment.
I worry a little that this may be too simplistic as we start adding things in 4.x again, but let's cross that bridge when we get to it.
Co-authored-by: Adam Harvey <adam@adamharvey.name>
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a newer Sourcegraph version from https://github.com/sourcegraph/sourcegraph/pull/40446.
This also adds a feature gate for sourcegraph 4.0 to src-cli to warn users when they use a too recent version of src-cli.
Closes https://github.com/sourcegraph/sourcegraph/issues/38969
Closes https://github.com/sourcegraph/sourcegraph/issues/38967
Test plan
Test suite and verified manually the 4.0 banner and previous functionality work.