Revert 4.0-pre changes #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2022
LawnGnome
added a commit
that referenced
this pull request
Aug 18, 2022
Whatever version string sniffing goreleaser is doing isn't firing, so let's just force it. I'll add a revert to #828 for this as well.
LawnGnome
added a commit
that referenced
this pull request
Aug 18, 2022
Whatever version string sniffing goreleaser is doing isn't firing, so let's just force it. I'll add a revert to #828 for this as well.
LawnGnome
force-pushed
the
revert-cheese-movement
branch
from
eec378b to
d883eae
Compare
eseliger
previously requested changes
Aug 22, 2022
Member
eseliger
left a comment
eseliger
left a comment
There was a problem hiding this comment.
Nice! Making sure we don't accidentally merge :)
Contributor
Author
|
This was reviewed by @eseliger last month, but he marked it "changes required" so we couldn't accidentally merge this. Re-requesting an approval just to unblock the machinery. |
camdencheek
approved these changes
Sep 21, 2022
unknwon
approved these changes
Sep 21, 2022
Contributor
|
|
Contributor
Author
You're a gem, Joe. Thanks! |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Whatever version string sniffing goreleaser is doing isn't firing, so let's just force it. I'll add a revert to #828 for this as well.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #827, and must be merged before 4.0.0 stable is released.
At the same time this is merged, we should ensure the changelog reflects any releases made on
3.43.Test plan
If #827 works, this will also work.