batches: Fix remote command - Batch Change ID not provided #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
approved these changes
Sep 16, 2022
| github.com/spf13/cobra v1.4.0 // indirect | ||
| github.com/spf13/pflag v1.0.5 // indirect | ||
| github.com/ssor/bom v0.0.0-20170718123548-6386211fdfcf // indirect | ||
| github.com/stretchr/objx v0.4.0 // indirect |
Member
There was a problem hiding this comment.
Wonder where that is coming from 🤔
Contributor
Author
There was a problem hiding this comment.
This is from me using testify's mock package
BolajiOlajide
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841
Changes to the GraphQL API broke the
batch remotecommand. UpdatedupsertEmptyBatchChangeto return the batch change ID and updatedcreateBatchSpecFromRawto accept the batch change ID.Test plan
Added Go Tests and did functional testing.