batches: check that docker is running when running src batch #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolajiOlajide
commented
Sep 26, 2022
BolajiOlajide
changed the title
LawnGnome
approved these changes
Sep 26, 2022
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
Great catch on the -j behaviour!
adeola-ak
approved these changes
Sep 26, 2022
Piszmog
approved these changes
Sep 26, 2022
eseliger
reviewed
Sep 27, 2022
eseliger
approved these changes
Sep 27, 2022
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* check docker version before batch * remove debug statement * create wrapper for fastcontext * move executeFastCommand into context.go * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37594
Test plan
Quit
Docker Desktopon your PC and run asrc batchcommand, you should get a descriptive error message that explains the need fordockerto make use ofsrc batch.