Add a add subcommand to extsvc #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context of scaletesting, it's pretty useful to be able to add code hosts on the fly, while toying with a test instance. This PR adds such a command.
burmudar
reviewed
Oct 6, 2022
burmudar
approved these changes
Oct 6, 2022
mrnugget
approved these changes
Oct 6, 2022
Contributor
mrnugget
left a comment
mrnugget
left a comment
There was a problem hiding this comment.
I know the mutation is called addExternalService, but all the other CRUD commands in src-cli use create as the verb: src users create, src orgs create, ... I think create would be better.
cmd/src/extsvc_add.go
Outdated
Comment on lines
50
to
54
| _, err := lookupExternalService(ctx, client, "", *nameFlag) | ||
| if err != errServiceNotFound { | ||
| return errors.New("service already exists") | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do you need to do that lookup or can't you be optimistic and have the server fail if there's a problem with a duplicate name?
Contributor
Author
There was a problem hiding this comment.
I naively assumed we didn't want duplicate and this wasn't supported. Fixed as we actually support this.
| } | ||
| return err | ||
| } else if ok { | ||
| fmt.Println("External service created:", *nameFlag) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Println("External service created:", *nameFlag) | |
| fmt.Println("External service created: ", *nameFlag) |
Contributor
Author
There was a problem hiding this comment.
This is going to print two spaces, with your suggestion:
~/work/src-cli US jh/extsvc-add $ go run ./cmd/src extsvc create -kind GITHUB -name testjhf config.json
External service created: testjhf
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add a add subcommand to extsvc In the context of scaletesting, it's pretty useful to be able to add code hosts on the fly, while toying with a test instance. This PR adds such a command. * fixup * Small fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of scaletesting, it's pretty useful to be able to add code hosts on the fly, while toying with a test instance. This PR adds such a command.
Test plan
Manually tested.