snapshot: add snapshot contents uploader #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
michaellzc
reviewed
Nov 28, 2022
danieldides
approved these changes
Nov 28, 2022
bobheadxi
force-pushed
the
11-28-snapshot_add_snapshot_contents_uploader
branch
from
ac9ce35 to
8dd6e5e
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Adds a command, src snapshot upload, that checks that all snapshot resources have been created and initiates parallel uploads for them with native usage of the Cloud Storage client. Co-authored-by: Michael Lin <mlzc@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command,
src snapshot upload, that checks that all snapshot resources have been created and initiates parallel uploads for them with native usage of the Cloud Storage client.This is a change from the previous plan to use signed URLs - a robust upload client does not exist for it, so we opt to generate service accounts instead to make use of the native Cloud Storage client that implements buffering/chunking/etc internally.
Closes https://github.com/sourcegraph/customer/issues/1613
Test plan