snapshot: improve docstrings #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellzc
approved these changes
Nov 29, 2022
danieldides
reviewed
Nov 29, 2022
| } | ||
|
|
||
| b := out.Block(output.Emoji(output.EmojiSuccess, "Commands generated - run them all to generate required database dumps:")) | ||
| _ = os.MkdirAll(srcSnapshotDir, os.ModePerm) |
There was a problem hiding this comment.
Is there a specific reason to ignore this error?
Member
Author
There was a problem hiding this comment.
It's a transient "set up in the background" type of thing, and ignoring MkdirAll error is a very common practice: https://sourcegraph.com/search?q=_+%3D+os.MkdirAll
There was a problem hiding this comment.
I assumed something like that, just wanted to double check. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve docstrings from the recently added
src snapshotcommands (#891), and also make some minor tweaks (mkdiron the snapshot output directory)Test plan
CI