batches: skip empty log output #923
Conversation
| prefix string | ||
| } | ||
|
|
||
| func (w *prefixedWriter) Write(p []byte) (int, error) { |
There was a problem hiding this comment.
I just checked the source of p and I think we will only ever stream 1 line at a time, either with the newline at the end, or not if the stream has ended and there is no newline (for example echo -n).
So that makes me think that we shouldn't even split the p in here at all - and would as a side-effect get that for free, while retaining actual empty log lines. How does that feel for you?
There was a problem hiding this comment.
Oh! Yeah true - that's better. I can just remove the loop then. It makes sense to me.
There was a problem hiding this comment.
Should just re-validate that - but from reading code it seems like our scanner on the other end of this stream would write in line-chunks :)
There was a problem hiding this comment.
Yeah, I just tested it, and it works. For both SSBC and local executions - the log output is consistent now.
Pushed a refactor.
BolajiOlajide
force-pushed
the
bo/fix-duplicate-log-output
branch
from
a14db80 to
20ef19c
Compare
Co-authored-by: Erik Seliger <erikseliger@me.com>
Co-authored-by: Erik Seliger <erikseliger@me.com>
Test plan
I added a unit test for this.