servegit: use more performant WalkDir #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkDir was introduced in go1.16 suits our use case while being more efficient. Test Plan: go test
mrnugget
reviewed
Feb 16, 2023
| } | ||
|
|
||
| err = filepath.Walk(root, func(path string, fi os.FileInfo, fileErr error) error { | ||
| err = filepath.WalkDir(root, func(path string, fi fs.DirEntry, fileErr error) error { |
Contributor
There was a problem hiding this comment.
Do you still need the if !fi.IsDir() below then?
Member
Author
There was a problem hiding this comment.
yes walkdir still goes over regular files.
mrnugget
approved these changes
Feb 22, 2023
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
WalkDir was introduced in go1.16 suits our use case while being more efficient. Test Plan: go test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WalkDir was introduced in go1.16 suits our use case while being more efficient.
Test Plan: go test